Launch Alarm V3 #6341
Launch Alarm V3 #6341
Conversation
github-actions
bot
added
Sound
|
I don't know what's up with the formatting. If it's failed, I don't know what it wants. I have not tested with format adjustments, but I imagine TSGUI being React based, and HTML tech, it should be no issue. |
prettier --write whateverfile.tsx 
|
|
Alarm bloat |
|
cd into the tgui folder so your end directory should be cmss13/tgui check the package.json but essentially tgui:prettier-fix runs prettier --write on all its subfiles to autoformat it. |
Hey, sorry, I tried installing yarn & googled several things to get it working. But I cannot update npm to run yarn, because my npm is out of date.
|
npm comes natively with node, although they technically can be packaged separately. Your issue seems to be that your node version is out of date, v16.15.1. What you need to do is to uninstall node.js, this should be simple on windows. Next, install the latest LTS version, visit https://nodejs.org/en/download/prebuilt-installer and don't install additional tools like Chocolatey when prompted. |
Thanks! I forgot about the GUI installer. I wanted to see what'd happen if I didn't uninstall, & at least on my computer, the installer detected my previous installation, and was able to run properly. Then with no further configuration, it worked perfectly. Linux is for the command line, and windows is not. |
|
check your paths and make sure there are no conflicts. |
Doesn't seem to be any in "Environment Variables." Looked through a few menus & sub menus. Guess this PR is ready to go and I am up to date with Node! |
There was a problem hiding this comment.
If the cycle alarm only plays the sound once then maybe it would be better to just gray out the button so that the user can't select it for the duration of the sound effect? Having a cancel button like with the other alarm just feels awkward because you need to click cancel again to play the sound even though it's not looping anymore. It's also not really "accurate" because the sound is no longer playing and playing_cycle_launch_announcement_alarm is still evaluating as true. Also, maybe it would be better if you can only select one alarm sound at a time? So if you select the main alarm you shouldn't be able to play the cycle alarm in parallel, either on accident or on purpose.
You can maybe use a cooldown instead and set it to the duration of the cycle alarm, then you could pass that in to tgui and if there is still some cooldown time left the cycle alarm message will be grayed out and disabled.
I was going to program it that way, but I figured I'd reuse the looping code, and then it didn't loop, so I was like "it does what I wanted anyway..."
That's a neat idea. EDIT: |
|
If you choose to keep things similar and need a reference for how to set up the cooldown, see #6333 , check forest's most recent commit. |
Is this the change I need to make to get this PR merged? |
I cannot approve or reject your pr; i'm a contributor like yourself. It was just my suggestion. |
ahh okay. I saw you in the reviewers' section, so I thought that you were a reviewer. |
|
As mentioned on the discord, I don't think any of these changes are necessary. Its more command's responsibility to communicate whether the marines are evaccing or not; its not necessarily clear to marines what sound means what; and this can just open up more miscommunication what's going on in a chaotic situation like fob evac. |
|
Going to convert this into a refactor. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Updates the Dropship Launch Alarms, and UI.
Explain why it's good for the game
Adds a new "Cycle" alarm. It has a similar, but distinctly different sound from the main alarm. This is for Pilots to say "I'm leaving soon, but not evacing" whilst the FOB is under siege. Plays only once, and requires re-pressing to play again so your ears don't get assaulted. Not allowing "bwoop" scenario from v0.
Buttons are also put into the section properly using the stack like the destinations.
Retained top right button in Launch Alarms for muscle memory. Plus it doesn't take up more space having it there.
Testing Photographs and Procedure
Screenshots & Videos
unknown_2024.05.27-06.32_clip_1.mp4
Changelog
🆑
add: Added Cycle Launch Alarm
ui: changed Dropship UI to accommodate two alarm buttons
refactor: Refactored some of the code to stop all alarms easily
soundadd: Added Cycle Alarm Sounds
/:cl: